Skip to content

Commit

Permalink
Merge pull request #617 from radiofrance/fix-golangci-lint-cfg-version
Browse files Browse the repository at this point in the history
maint: pin version of golangci-lint config file refs
  • Loading branch information
antoinegelloz authored Oct 22, 2024
2 parents 0bbb94b + 0944341 commit afd0fe7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
env:
# renovate: datasource=github-releases depName=radiofrance/lint-config
LINT_CONFIG_VERSION: v1.0.0
LINT_CONFIG_VERSION: v1.0.1
steps:
- uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
Expand Down
8 changes: 6 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@ docs: build

qa: lint test

lint:
curl -o .golangci.yml https://raw.githubusercontent.com/radiofrance/lint-config/main/.golangci.yml
# renovate: datasource=github-releases depName=radiofrance/lint-config
LINT_CONFIG_VERSION=v1.0.1
lint: ## Lint source code
curl -o .golangci.yml -sS "https://raw.githubusercontent.com/radiofrance/lint-config/${LINT_CONFIG_VERSION}/.golangci.yml"
golangci-lint run --verbose

PKG := "./..."
Expand All @@ -48,6 +50,8 @@ test: ## Run tests
sed 's/PAUSE/$(BLUE)PAUSE$(RESET)/g' | \
sed 's/PASS/$(GREEN)PASS$(RESET)/g' | \
sed 's/FAIL/$(RED)FAIL$(RESET)/g'

coverage: test ## Run test, then generate coverage html report
@go tool cover -html=coverage.out -o coverage.html
@echo "To open the html coverage file, use one of the following commands:"
@echo "open coverage.html on mac"
Expand Down

0 comments on commit afd0fe7

Please sign in to comment.