Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logrus with pterm #435

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Replace logrus with pterm #435

merged 5 commits into from
Jan 25, 2024

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@antoinegelloz antoinegelloz requested review from julienvey, graillus and a team as code owners December 8, 2023 16:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (edba790) 65.87% compared to head (359d2e8) 64.80%.
Report is 3 commits behind head on main.

Files Patch % Lines
internal/logger/logger.go 61.40% 37 Missing and 7 partials ⚠️
pkg/kubernetes/pod.go 0.00% 9 Missing ⚠️
pkg/report/report.go 0.00% 8 Missing ⚠️
pkg/dib/build.go 16.66% 5 Missing ⚠️
pkg/dib/generate_dag.go 0.00% 4 Missing ⚠️
pkg/report/template.go 0.00% 2 Missing ⚠️
pkg/goss/executor_kubernetes.go 80.00% 1 Missing ⚠️
pkg/kaniko/context_remote.go 66.66% 1 Missing ⚠️
pkg/kaniko/executor_kubernetes.go 66.66% 1 Missing ⚠️
pkg/kaniko/s3.go 0.00% 1 Missing ⚠️
... and 1 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   65.87%   64.80%   -1.08%     
==========================================
  Files          32       33       +1     
  Lines        2031     2145     +114     
==========================================
+ Hits         1338     1390      +52     
- Misses        618      673      +55     
- Partials       75       82       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinegelloz antoinegelloz requested review from Thibaut-gauvin and gminh474 and removed request for a team, julienvey and graillus January 22, 2024 17:51
@Thibaut-gauvin Thibaut-gauvin merged commit efa04e4 into main Jan 25, 2024
5 checks passed
@Thibaut-gauvin Thibaut-gauvin deleted the replace-logrus branch January 25, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants