Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup and refactoring #32

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

RobSchoenaker
Copy link
Collaborator

  • Added .UseIISIntegration() to Program.cs or debugging could fail
  • Keep Serialized payload in Message, makes sending to a lot of clients faster
  • WebSocketConnection introduced, so that iterating on the dictionary is easier

@radu-matei
Copy link
Owner

Could you investigate why the build is failing, please?

@RobSchoenaker
Copy link
Collaborator Author

The build fails on the Test project. I did not change anything to that, so I suppose that should fail :)

@RobSchoenaker
Copy link
Collaborator Author

OK, fixed the tests and should merge just fine now.

@radu-matei
Copy link
Owner

Hi!
Thank you very much for the contribution you provided so far!

Sorry for delaying this, I have been focusing on different projects lately, but I would love to get back working on this.
In order to do this, I would love to enable you people to contribute directly to the projects. Please let me know if you want to be granted write access to branches of this repo.

Thanks,
Radu M

@RobSchoenaker
Copy link
Collaborator Author

If possible, yes. Makes contributing a LOT easier :)

@radu-matei
Copy link
Owner

Ok.
Since there will be no support for .NET Core before 2.1 for SignalR (will document this soon), I believe there is a strong point in continuing support for this library.

I added people who responded as contributors, guidelines coming soon :)

Thanks!

@radu-matei
Copy link
Owner

Hi, @RobSchoenaker - could you please take a look and rebase this?

Thanks!

@RobSchoenaker
Copy link
Collaborator Author

I will rebase this and create a PR for my additional changes. Will be some job :)

@Henry00IS
Copy link
Collaborator

I am not quite sure what was changed in this PR. But I am currently adding return values and exceptions. That means when you call a remote method it's literally the same as a local method, returns a thing or throws an exception. I am just asking if there are significant logic changes here or is it all the same still? If this gets merged before I am done will we have a have a massive merge conflict? Hmm...

@RobSchoenaker
Copy link
Collaborator Author

This was a huge commit. I will merge your changes with it. No worries. The changes I made include:

  • State on a connection, so you know WHO sent something and you can target individuals
  • Grouping support (either via a lambda for dynamic groups or via fixed groups)
  • Major speedups on sending something to a high number of connections. The serialization is done ony once, and not per connection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants