-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup and refactoring #32
base: master
Are you sure you want to change the base?
Speedup and refactoring #32
Conversation
RobSchoenaker
commented
May 17, 2017
- Added .UseIISIntegration() to Program.cs or debugging could fail
- Keep Serialized payload in Message, makes sending to a lot of clients faster
- WebSocketConnection introduced, so that iterating on the dictionary is easier
- Keep Serialized payload in Message, makes sending to a lot of clients faster - WebSocketConnection introduced, so that iterating on the dictionary is easier
…s, rooms, filter by age, etc.
Could you investigate why the build is failing, please? |
The build fails on the Test project. I did not change anything to that, so I suppose that should fail :) |
OK, fixed the tests and should merge just fine now. |
Hi! Sorry for delaying this, I have been focusing on different projects lately, but I would love to get back working on this. Thanks, |
If possible, yes. Makes contributing a LOT easier :) |
Ok. I added people who responded as contributors, guidelines coming soon :) Thanks! |
Hi, @RobSchoenaker - could you please take a look and rebase this? Thanks! |
I will rebase this and create a PR for my additional changes. Will be some job :) |
I am not quite sure what was changed in this PR. But I am currently adding return values and exceptions. That means when you call a remote method it's literally the same as a local method, returns a thing or throws an exception. I am just asking if there are significant logic changes here or is it all the same still? If this gets merged before I am done will we have a have a massive merge conflict? Hmm... |
This was a huge commit. I will merge your changes with it. No worries. The changes I made include:
|