Save build log

[stappersg]

At least an attempt to save build log.
Actual need was saving ./test-suite.log

[melroy89]

It was pseudo code ;P

Check failure on line 23 in .github/workflows/linux.yaml
GitHub Actions / .github/workflows/linux.yaml

Invalid workflow file

You have an error in your yaml syntax on line 23

if you only want to save test-suite.log and there is an error in the syntax anyways. Try this.. (see below)

[melroy89]

Suggested change

	path: *.log
	path: test-suite.log

[melroy89]

Suggested change

	path: *.log
	path: test-suite.log

[melroy89]

Etc. etc. for the rest as well

[RICCIARDI-Adrien]

I also suggest to add different names for the artifacts, otherwise they will collide.

[RICCIARDI-Adrien]

Maybe use a unique name like alpine-${{ matrix.compiler }}-log-file.

[RICCIARDI-Adrien]

Maybe use a unique name like debian-${{ matrix.compiler }}-log-file.

[RICCIARDI-Adrien]

And so on for all the distros !

[stappersg]

On Thu, Dec 05, 2024 at 01:43:54PM -0800, Adrien RICCIARDI wrote: > @@ -31,6 +36,11 @@ jobs: CC: ${{ matrix.compiler }} run: | test/test_build.sh debian + - uses: ***@***.*** + if: always() + with: + name: log-file Maybe use a unique name like debian-${{ matrix.compiler }}-log-file.

Work in progress ...

[RICCIARDI-Adrien]

Sorry, I forgot that there were 2 Ubuntu versions !
I suggest ubuntu-${{ matrix.ubuntu_version }}-${{ matrix.compiler }}-log-file.

[RICCIARDI-Adrien]

You can even drop the initial ubuntu, using only ${{ matrix.ubuntu_version }}-${{ matrix.compiler }}-log-file.

[stappersg]

On Thu, Dec 05, 2024 at 02:20:48PM -0800, Adrien RICCIARDI wrote: You can even drop the initial `ubuntu`, using only `${{ matrix.ubuntu_version }}-${{ matrix.compiler }}-log-file`.

Nice. Done! Groeten Geert Stappers -- Silence is hard to parse

[RICCIARDI-Adrien]

Artifacts are present in the workflow view, this looks good to me !

[Neustradamus]

@RICCIARDI-Adrien: What do you think?

[stappersg]

@RICCIARDI-Adrien: What do you think?

I think that Neustradamus should try their/her/his privilege to approve merge requests for this project.

[melroy89]

Sorry that my approval doesn't count 😜

[Neustradamus]

@stappersg: I know but I do not use my "power" ^^

[RICCIARDI-Adrien]

@Neustradamus We all agree to merge this PR, what are we waiting for ?

[stappersg]

On Fri, Dec 06, 2024 at 01:26:09PM -0800, Neustradamus wrote: @stappersg: I know but I do not use my "power" ^^

As uncle Ben once said "With great power comes great responsebility." @Neustradamus: Please take your responsebility. Groeten Geert Stappers -- Silence is hard to parse

[stappersg]

On Sat, Dec 07, 2024 at 09:07:59PM -0800, Neustradamus wrote: @Neustradamus approved this pull request.

Thank you. Please do what I did in #240, click on 'Merge pull request'. Groeten Geert Stappers -- Silence is hard to parse

[melroy89]

Please do what I did in #240, click on 'Merge pull request'.

That depends how you want to work together and what your WoW is. I normally like to merge my own PRs myself, to ensure a PR isn't merge too fast, causing possible regression for example.