fix: improve file checks for procfs knobs #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stappersg
approved these changes
Jan 2, 2025
|
I'm thinking we should NOT merge this, and instead find a way to annotate for CodeQL that this is not vulnerable; specifically, if the file doe NOT exist, the write never happens. |
|
On Thu, Jan 02, 2025 at 12:04:11PM -0800, Robin H. Johnson wrote:
I'm thinking we should NOT merge this, and instead find a way to
annotate for CodeQL that this is not vulnerable; specifically, if the
file doe *NOT* exist, the write never happens.
For what it is worth: I'm fine with stopping the CodeQL experiment.
Groeten
Geert Stappers
--
Silence is hard to parse
|
CodeQL checks flagged this pattern as a TOCTOU race. Signed-off-by: Robin H. Johnson <[email protected]>
robbat2
force-pushed
the
robbat2/20250102-privsep
branch
from
945a580 to
133fed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeQL checks flagged this pattern as a TOCTOU race.