Avoid libbsd header with libc strlcpy #262
Conversation
|
Approving "workflows", to find out what breaks ... |
While radvd-project#256 avoided the libbsd library dependency, this avoids the header requirement except when libbsd is actually needed. Signed-off-by: Yaakov Selkowitz <[email protected]>
|
I'm not happy how poor the two purposed changes are documented in the commit. This merge request will be closed. No hard feelings. |
So far I have proposed two different ways of avoiding the unnecessary inclusion of the libbsd headers, and others are possible, but I'm not psychic. I have yet to hear any feedback on the second, and you could always add to the commit message when merging.
To what end? Are you not planning on fixing this? Are you planning on creating your own commit to this fix?
I find this baffling and counterproductive. Does @robbat2 concur with your decision? |
|
> This merge request will be closed.
To what end?
For a fresh start
|
|
@stappersg i didn't even have time to review their 2nd version before you closed this. It's supposed to be iterative development; and you don't need "a fresh start" in a constructive environment. |
|
Re-opening this so that the CI checking can run on it. |
|
Acknowledge on "it is an iterative process".
Consider that I have it in mind.
Groeten
Geert Stappers
--
Silence is hard to parse
|
While #256 avoided the libbsd library dependency, this avoids the header requirement except when libbsd is actually needed.