DataBoundFormComponent: Generate FieldIdentifier if ValueChanged given #2291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i took a page out of FluentUI's book and noticed that they also make the field identifier if only ValueChanged is given
https://github.com/microsoft/fluentui-blazor/blob/dev/src/Core/Components/Base/FluentInputBase.cs#L315-L322
this allows validations to work if the user makes a one way binding (
Value=@someProperty) and fills in ValueChanged(ValueChanged=@(value => SomeProperty=value)). we have come across the need to fill in the expression a few times in our application, so i have made a PR to help us (and anyone else) make validations work faster :)this was tested in the
RequiredValidatorDropDown.razorby changing@[email protected]inTValue=string [email protected] ValueChanged=@(value => model.CategoryName=value)and worked nicely as both validations triggered.