Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server operators to set dropped CTF flag return time #304

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

GooberRF
Copy link
Contributor

@GooberRF GooberRF commented Nov 1, 2024

This PR adds the $DF CTF Flag Return Time config item to dedicated_server.txt

This option allows the server operator to set the time after a flag is dropped before it automatically returns to base. If unset, the option defaults to 25000 ms (stock game value - ie. no change).

@is-this-c
Copy link
Contributor

What about $DF CTF Flag Drop Time? Is it not a problem that players are not going to know what a server set it to? Is this feature needed?

@GooberRF
Copy link
Contributor Author

GooberRF commented Nov 1, 2024

Is it not a problem that players are not going to know what a server set it to?

While I would prefer clients knew, clients already don't know many server details that they really ought to - kill limit, cap limit, spawn protection duration, global damage multiplier, amp damage multiplier, etc.

Clients should know about all of those things, and if ever a method exists for them to know them, this value should be added to that list as well.

What about $DF CTF Flag Drop Time?

From the POV of a general user, this seems less clear. As-is, the server operator sets the "return time" - it's only possible for the flag to return when it's dropped, so I really can't see any cause for confusion.

@rafalh
Copy link
Owner

rafalh commented Nov 18, 2024

I like the current name. I also don't see it as a big problem that players don't know it when joining the server. If you join a modded server you also don't know how it works but after playing for a bit you get to learn it. Having some commands or UI for that in some far future could be a good addition but I don't think it should block this change.

@GooberRF GooberRF requested a review from rafalh November 18, 2024 21:54
Copy link
Owner

@rafalh rafalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve one more comment and fix conflicts

game_patch/multi/server.cpp Outdated Show resolved Hide resolved
@GooberRF GooberRF requested a review from rafalh November 19, 2024 04:32
@rafalh rafalh merged commit 5dfb486 into rafalh:master Nov 20, 2024
2 checks passed
@GooberRF GooberRF deleted the flagreturntime branch November 22, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants