Erase rf::local_player from g_player_additional_data_map upon leaving server.
#317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is-this-c
changed the title
rf::local_player from g_player_additional_data_maprf::local_player from g_player_additional_data_map upon leaving server.
rafalh
requested changes
Dec 10, 2024
game_patch/multi/network.cpp
Outdated
| @@ -891,6 +891,10 @@ FunHook<void()> multi_stop_hook{ | |||
| // Clear server info when leaving | |||
| g_df_server_info.reset(); | |||
| multi_stop_hook.call_target(); | |||
| if (rf::local_player) { | |||
| extern std::unordered_map<rf::Player*, PlayerAdditionalData> g_player_additional_data_map; | |||
There was a problem hiding this comment.
I don't really like this way of accessing this variable. It wasn't intended to be public.
Could you add in player.cpp a function which removes the player from the map? e.g. remove/reset_player_additional_data(Player*)
rafalh
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures
received_ac_statusetc. is cleared.