Cast required value to str before checking its length

rafalp · Nov 12, 2023 · 154dae6 · 154dae6
1 parent 3b9414d
commit 154dae6
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/frontend/src/components/form.js b/frontend/src/components/form.js
@@ -1,6 +1,6 @@
 import React from "react"
-import { required } from "misago/utils/validators"
-import snackbar from "misago/services/snackbar"
+import { required } from "../utils/validators"
+import snackbar from "../services/snackbar"
 
 let validateRequired = required()
 
@@ -77,10 +77,7 @@ export default class extends React.Component {
       optional: (this.state.validators.optional || {})[name],
     }
 
-    let requiredError = false
-    if (validators.required) {
-      requiredError = validateRequired(value) || false
-    }
+    let requiredError = validateRequired(value) || false
 
     if (validators.required) {
       if (requiredError) {

diff --git a/frontend/src/utils/validators.js b/frontend/src/utils/validators.js
@@ -5,7 +5,7 @@ const USERNAME_ALPHANUMERIC = new RegExp("[0-9a-z]", "i")
 
 export function required(message) {
   return function (value) {
-    if (value === false || value === null || value.trim().length === 0) {
+    if (value === false || value === null || String(value).trim().length === 0) {
       return message || gettext("This field is required.")
     }
   }

diff --git a/misago/static/misago/js/misago.js b/misago/static/misago/js/misago.js
diff --git a/misago/static/misago/js/misago.js.map b/misago/static/misago/js/misago.js.map