-
-
Notifications
You must be signed in to change notification settings - Fork 527
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
#893: moved missing validation to serializers in posting endpoints
- Loading branch information
Showing
8 changed files
with
86 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,22 @@ | ||
from rest_framework import serializers | ||
|
||
from misago.threads import moderation | ||
|
||
from . import PostingEndpoint, PostingMiddleware | ||
|
||
|
||
class CloseMiddleware(PostingMiddleware): | ||
def use_this_middleware(self): | ||
return self.mode == PostingEndpoint.START and 'close' in self.request.data | ||
return self.mode == PostingEndpoint.START | ||
|
||
def get_serializer(self): | ||
return CloseSerializer(data=self.request.data) | ||
|
||
def post_save(self, serializer): | ||
if self.thread.category.acl['can_close_threads']: | ||
try: | ||
close = bool(self.request.data['close']) | ||
except (TypeError, ValueError): | ||
close = False | ||
|
||
if close: | ||
if serializer.validated_data.get('close'): | ||
moderation.close_thread(self.request, self.thread) | ||
|
||
|
||
class CloseSerializer(serializers.Serializer): | ||
close = serializers.BooleanField(required=False, default=False) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,27 @@ | ||
from rest_framework import serializers | ||
|
||
from misago.threads import moderation | ||
|
||
from . import PostingEndpoint, PostingMiddleware | ||
|
||
|
||
class HideMiddleware(PostingMiddleware): | ||
def use_this_middleware(self): | ||
return self.mode == PostingEndpoint.START and 'hide' in self.request.data | ||
return self.mode == PostingEndpoint.START | ||
|
||
def get_serializer(self): | ||
return HideSerializer(data=self.request.data) | ||
|
||
def post_save(self, serializer): | ||
if self.thread.category.acl['can_hide_threads']: | ||
try: | ||
hide = bool(self.request.data['hide']) | ||
except (TypeError, ValueError): | ||
hide = False | ||
|
||
if hide: | ||
if serializer.validated_data.get('hide'): | ||
moderation.hide_thread(self.request, self.thread) | ||
self.thread.update_all = True | ||
self.thread.save(update_fields=['is_hidden']) | ||
|
||
self.thread.category.synchronize() | ||
self.thread.category.update_all = True | ||
|
||
|
||
class HideSerializer(serializers.Serializer): | ||
hide = serializers.BooleanField(required=False, default=False) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,23 @@ | ||
from rest_framework import serializers | ||
|
||
from . import PostingEndpoint, PostingMiddleware | ||
|
||
|
||
class ProtectMiddleware(PostingMiddleware): | ||
def use_this_middleware(self): | ||
return self.mode == PostingEndpoint.EDIT and 'protect' in self.request.data | ||
return self.mode == PostingEndpoint.EDIT | ||
|
||
def get_serializer(self): | ||
return ProtectSerializer(data=self.request.data) | ||
|
||
def post_save(self, serializer): | ||
if self.thread.category.acl['can_protect_posts']: | ||
try: | ||
self.post.is_protected = bool(self.request.data['protect']) | ||
self.post.is_protected = serializer.validated_data.get('protect', False) | ||
self.post.update_fields.append('is_protected') | ||
except (TypeError, ValueError): | ||
pass | ||
|
||
|
||
class ProtectSerializer(serializers.Serializer): | ||
protect = serializers.BooleanField(required=False, default=False) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters