New plugin discovery logic (without tests)

Dockerfile

@@ -28,13 +28,13 @@ ADD plugins /app/plugins
 WORKDIR /app/
 
 # Install Misago requirements
-# RUN pip install --upgrade pip && \
-#     pip install -r /app/requirements.txt && \
-#     pip install pip-tools
+RUN pip install --upgrade pip && \
+    pip install -r /app/requirements.txt && \
+    pip install pip-tools
 
 # Bootstrap plugins
 RUN ./dev bootstrap_plugins
 
 EXPOSE 8000
 
-CMD python manage.py runserver 0.0.0.0:8000
+CMD python manage.py runserver 0.0.0.0:8000 --noreload

dev-docs/plugins/index.md

@@ -1 +1,21 @@
-# Plugin guide
+# Plugin guide
+
+Misago implements a plugin system that enables developers to customize and extend the core functionality of the software. This plugin system itself extends existing Django applications mechanism.
+
+>  plugins vs. forking note
+
+
+## Plugin installation
+
+
+## Writing custom plugin
+
+- django applications mechanism
+- plugin structure
+- plugins vs. forking
+
+
+## Hooks
+
+- how to hooks
+- hook reference

devproject/settings.py

@@ -13,7 +13,7 @@
 
 import os
 
-from misago import plugin_loader
+from misago import discover_plugins
 from misago.settings import *
 
 
@@ -158,9 +158,9 @@
 
 CSRF_FAILURE_VIEW = "misago.core.errorpages.csrf_failure"
 
-PLUGINS_LIST_PATH = os.path.join(os.path.dirname(BASE_DIR), "plugins.txt")
+PLUGINS_DIRECTORY = os.environ.get("MISAGO_PLUGINS")
 
-INSTALLED_PLUGINS = plugin_loader.get_plugins_apps()
+INSTALLED_PLUGINS = discover_plugins(PLUGINS_DIRECTORY)
 
 # Combine Misago's default installed apps with plugins
 INSTALLED_APPS = [

misago/__init__.py

@@ -1,4 +1,4 @@
-from .plugins.loader import plugin_loader
+from .plugins import MisagoPlugin, discover_plugins
 
 
 __version__ = "0.39.0"

misago/plugins/__init__.py

@@ -0,0 +1,2 @@
+from .discover import discover_plugins
+from .manifest import MisagoPlugin

misago/plugins/discover.py

@@ -0,0 +1,31 @@
+import sys
+from pathlib import Path
+from typing import List
+
+
+def discover_plugins(plugins_path: str | None) -> List[str]:
+    if not plugins_path:
+        return []
+
+    plugins_path_obj = Path(plugins_path)
+    if not plugins_path_obj.is_dir():
+        return []
+
+    return discover_plugins_in_directory(plugins_path_obj)
+
+
+def discover_plugins_in_directory(plugins_path: Path) -> List[str]:
+    plugins_apps: List[str] = []
+
+    for plugin_path in plugins_path.glob("*/*/misago_plugin.py"):
+        plugin_package = plugin_path.parent
+
+        # Add plugin to Python path so its importable
+        plugin_dir = str(plugin_package.parent)
+        if plugin_dir not in sys.path:
+            sys.path.append(plugin_dir)
+
+        # Add plugin to apps to make Django include it
+        plugins_apps.append(plugin_package.name)
+
+    return plugins_apps

misago/plugins/manifest.py

@@ -0,0 +1,15 @@
+from dataclasses import dataclass
+from typing import Optional
+
+
+@dataclass(frozen=True)
+class MisagoPlugin:
+    name: str
+    description: Optional[str] = None
+    license: Optional[str] = None
+    icon: Optional[str] = None
+    color: Optional[str] = None
+    version: Optional[str] = None
+    author: Optional[str] = None
+    homepage: Optional[str] = None
+    repo: Optional[str] = None

plugins/example-plugin/example_plugin/misago_plugin.py

@@ -0,0 +1,6 @@
+from misago import MisagoPlugin
+
+
+manifest = MisagoPlugin(
+    name="My example plugin",
+)