Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories page refactor #1702

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Categories page refactor #1702

merged 3 commits into from
Dec 20, 2023

Conversation

rafalp
Copy link
Owner

@rafalp rafalp commented Dec 20, 2023

This PR refactor's categories page view to expose data to templates in a manner that doesn't rely on mutating the Category instances. Also makes categories page use a little less memory because of prefetching last posters instead of joining them.

Last thread data will not propagate all the way to the top category, so new categories list will no longer display same thread twice.

Fixes the CSS for last thread message.

Adds two plugin outlets to the categories page, CATEGORIES_LIST_START and CATEGORIES_LIST_END.

Removes React.js from categories page (#1674 epic)

Removes categories API (#1531 epic)

Fixes #1683

@rafalp rafalp added area: frontend This issue involves JavaScript, React.js and Node area: backend This issue involves Python, Django or dependency (eg. database) labels Dec 20, 2023
@rafalp rafalp added this to the 0.39 milestone Dec 20, 2023
@rafalp rafalp self-assigned this Dec 20, 2023
@coveralls
Copy link

coveralls commented Dec 20, 2023

Coverage Status

coverage: 98.598% (+0.008%) from 98.59%
when pulling ca90357 on fix-1683-categories-page-redesign
into 0412930 on main.

@rafalp rafalp merged commit 7e86ec5 into main Dec 20, 2023
2 checks passed
@rafalp rafalp deleted the fix-1683-categories-page-redesign branch December 20, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend This issue involves Python, Django or dependency (eg. database) area: frontend This issue involves JavaScript, React.js and Node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove React.js from categories page
2 participants