update path to search component in frontend #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I knew what the problem was the moment I saw email's subject 💀 If components in search are using capitalized names, the dir should follow it too. But those components will be nuked anyway in few months as part of the #1674 epic, so lets just fix the frontend build on systems with case sensitive filesystems. |
rafalp
approved these changes
Aug 21, 2024
|
Forgot about this. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to run this locally, but it failed. The navbar, profile dropdown, sign-in/register buttons and search functions were not working.
I saw that the
navbarandsearch-overlaycomponents were referencing what looked to be a renamedsearchcomponent directory.After fixing the imports, the issue resolved itself.
@rafalp