-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace per-post read tracker with per-thread one #1800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalp
added
area: backend
This issue involves Python, Django or dependency (eg. database)
feature: read tracker
Tracks read and unread threads and posts
feature: threads list
Lists of threads
feature: thread page
Thread and private thread pages
feature: categories
Categories page
labels
Aug 24, 2024
There are 146 tests failing. I will fix those in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: backend
This issue involves Python, Django or dependency (eg. database)
feature: categories
Categories page
feature: read tracker
Tracks read and unread threads and posts
feature: thread page
Thread and private thread pages
feature: threads list
Lists of threads
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back "classic" read tracker to Misago.
This tracker actually tracks two separate read times:
Whenever user sees new post, we create or update existing entry for a thread. We also check if there are other unread threads in this category and if there aren't, we update the category entry. This second step forums perform life, but we could delay it to a celery task to keep thread view speedy.
Fixes #956 #1585 #1618
Superseds #1449
TODO
misago/mark_as_read/...
unread_private_threads
if its not zeroclearreadtracker
management command