Login redirection fix (#1242)

Fix a problem where Next.js dynamic segment names would end up in redirected urls
rage · Sep 21, 2023 · ca74f4f · ca74f4f
1 parent e8524f5
commit ca74f4f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/frontend/lib/authentication.ts b/frontend/lib/authentication.ts
@@ -55,12 +55,12 @@ export const signIn = async (
   }
 
   try {
-    const { href } = JSON.parse(rawRedirectLocation)
+    const { url } = JSON.parse(rawRedirectLocation)
 
     if (redirect) {
       setTimeout(() => {
-        if (href) {
-          Router.push(href, undefined, { shallow, locale })
+        if (url) {
+          Router.push(url, undefined, { shallow, locale })
         } else {
           Router.back()
         }

diff --git a/frontend/lib/redirect.ts b/frontend/lib/redirect.ts
@@ -19,7 +19,7 @@ export default function redirect({
     nookies.set(
       context,
       "redirect-back",
-      JSON.stringify({ as: context.asPath, href: context.pathname }),
+      JSON.stringify({ url: context.asPath }),
       {
         maxAge: 20 * 60,
         path: "/",