createcertificate should not show success on non-generated

rage · Aug 25, 2023 · e976ddd · e976ddd
1 parent c5b145b
commit e976ddd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 17 deletions.
diff --git a/frontend/hooks/useCertificate.tsx b/frontend/hooks/useCertificate.tsx
@@ -175,6 +175,9 @@ export const useCertificate = ({
     try {
       dispatch({ type: "GENERATE_CERTIFICATE" })
       const res = await createCertificate(course.slug)
+      if (!res) {
+        throw new Error("No generated certificate received")
+      }
       dispatch({ type: "RECEIVE_GENERATED_CERTIFICATE", payload: res })
       onReceiveGeneratedCertificateSuccess?.()
       initialState.current = {

diff --git a/frontend/lib/certificates.ts b/frontend/lib/certificates.ts
@@ -25,22 +25,17 @@ export const checkCertificate = async (courseSlug: string) => {
 export const createCertificate = async (courseSlug: string) => {
   const accessToken = getAccessToken(undefined)
 
-  try {
-    const res = await fetch(`${SERVICE_URL}/create/${courseSlug}`, {
-      method: "POST",
-      headers: {
-        "Content-Type": "application/json",
-        Authorization: `Bearer ${accessToken}`,
-      },
-    })
-    if (res.ok) {
-      return res.json()
-    }
-    const e = await res.json()
-    console.log(e)
-    return null
-  } catch (e) {
-    console.log(e)
-    return null
+  const res = await fetch(`${SERVICE_URL}/create/${courseSlug}`, {
+    method: "POST",
+    headers: {
+      "Content-Type": "application/json",
+      Authorization: `Bearer ${accessToken}`,
+    },
+  })
+  if (res.ok) {
+    return res.json()
   }
+  const e = await res.json()
+  console.log(e)
+  return null
 }