Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor new layout: responsive course card #1188

Merged
merged 4 commits into from
May 19, 2023

Conversation

mipyykko
Copy link
Collaborator

Originally this was a refactor to named grid areas, but that made the responsive layout a bit annoying to accomplish so I just used flexbox with a bit of container queries. These are only fully supported in the newer browsers, but a polyfill that is conditionally loaded should fix this for the rest.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #1188 (cd541fa) into master (6e78649) will not change coverage.
The diff coverage is n/a.

❗ Current head cd541fa differs from pull request most recent head 6ad5798. Consider uploading reports for the commit 6ad5798 to get more accurate results

@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   65.51%   65.51%           
=======================================
  Files         124      124           
  Lines        5222     5222           
  Branches     1160     1160           
=======================================
  Hits         3421     3421           
  Misses       1677     1677           
  Partials      124      124           
Flag Coverage Δ
backend 65.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mipyykko mipyykko merged commit 5c76e4c into master May 19, 2023
4 checks passed
@mipyykko mipyykko deleted the refactor-new-course-card-responsive branch May 19, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant