Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter ended courses from modules page #1204

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

mipyykko
Copy link
Collaborator

@mipyykko mipyykko commented Jun 6, 2023

  • active courses first, then upcoming (should it be the other way around?), ended not shown
  • the order in database (order, studyModuleOrder) is not used for now, probably should
  • if there are ended courses in the module, link to the course catalogue with that specific module and tag
  • course catalogue now supports query parameters (tag, status) that update in the URL
  • course catalogue shows a status of what is shown and with which criteria
  • ended courses show up as greyed out(ish)
  • fixed front page bottom margin

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1204 (2a331fd) into master (dc0849d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   64.15%   64.15%           
=======================================
  Files         124      124           
  Lines        5306     5306           
  Branches     1234     1234           
=======================================
  Hits         3404     3404           
  Misses       1773     1773           
  Partials      129      129           
Flag Coverage Δ
backend 64.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mipyykko mipyykko merged commit cb4fccb into master Jun 6, 2023
@mipyykko mipyykko deleted the new-layout-filter-ended-courses branch June 6, 2023 15:17
Redande added a commit that referenced this pull request Jun 7, 2023
Redande added a commit that referenced this pull request Jun 7, 2023
* Tweaks to the new layout (WIP)

* More tweaks

* Unify color schemes and improve module background

* Small fixes after rebasing PR #1204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant