Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: new layout header #1227

Merged
merged 2 commits into from
Aug 24, 2023
Merged

WIP: new layout header #1227

merged 2 commits into from
Aug 24, 2023

Conversation

mipyykko
Copy link
Collaborator

@mipyykko mipyykko commented Aug 24, 2023

Two-tier header: HY logo, (possible HY navigation), language switcher; MOOC logo and navigation below that.

Top header does not have any navigation currently -- semantically it should navigate inside the HY site, but we're not actually under that, so...? HY logo is also missing the link to the website.

The navigation on the mobile has changed to using a drawer instead of a dropdown. A possible multiple tier drawer is not implemented; does support nesting but not used for now. The menu should probably have more content. The profile/login/logout buttons on the navigation bar have not been touched yet.

  • adds font(s) -- the current duplication for the same font is just to keep some parts that may use the variables working
  • adds palette -- theme.palette.common.*
  • adds some styling to the components on the theme level -- button first and foremost; this must still be revisited as most of the buttons below the header will be wrong
  • adds some SVG icons copied from the HY design system

@mipyykko mipyykko merged commit abe7327 into master Aug 24, 2023
6 checks passed
@mipyykko mipyykko deleted the wip-new-layout-header branch August 24, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant