Skip to content

Refactored extraction of v param in youtube links #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtallant wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactored extraction of v param in youtube links #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions app/helpers/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,7 @@ def video_embed_tag(link)

if domain.include?("youtube")

query_string = link.split("?").last
if query_string
parameters = query_string.split("&")
if parameters
id_param = parameters.select { |parameter| parameter[0..1] == "v=" }.first
if id_param
id = id_param.split("=").last
end
end
end
link.split("v=")[1].split("&")[0]

return "<iframe width='853'
height='505'
Expand Down