Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scanf #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added scanf #59

wants to merge 3 commits into from

Conversation

shubham7298
Copy link

@shubham7298 shubham7298 commented Dec 14, 2018

#Added Inputting a variable functionality

Types of Changes

  • Bux Fix
  • [ x] Added new feature

Please describe the changes you have made, be as descriptive as you can

I have added a feature to input a single variable only.
If user is trying to get input of an uninitialized input then in converted code the variable automatically gets converted to 'float' datatype.

If you have added any new feature please add screenshot of the output, how it has been changed after addition of the new feature

screenshot from 2018-12-14 14-11-28

Checklist

Please checkout the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask .Join our gitter channel and feel free to ask.

  • [x ] I have read the Contribution GuideLines.
  • [x ] I have added tests that prove my fix is effective or that my feature works.
  • [x ] I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Thank You !

Copy link

@ShreyanshDarshan ShreyanshDarshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code can be altered a little to include multiple variables in a single input statement by using a queue.

Copy link
Contributor

@sumanthd17 sumanthd17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes before we merge this PR - look at the comments


start
initialise hi=20
initialise int a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of having 2 lines for initializing and then taking input i feel it is better to do it in the same line.
Eg. input int a;
We then initialize the variable a and take the input. This way we can initialize any type of variable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to work on this issue after this PR is merged.There is no point of adding features if it is not merge at the end.
Btw, thanx for your suggestion and will look forward for your suggestions and reviews in future.

testfiles/code0.txt Show resolved Hide resolved
@shubham7298 shubham7298 mentioned this pull request Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants