Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coerced pretty print test #1084

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Coerced pretty print test #1084

merged 1 commit into from
Sep 14, 2023

Conversation

aidanharan
Copy link
Contributor

Coerced test that uses different format of SQL.

Failure:
RelationTest#test_0024_relations don't load all records in #pretty_print [/usr/local/bundle/bundler/gems/rails-bd4996bdfddb/activerecord/test/cases/relations_test.rb:2148]:
Query pattern(s) /LIMIT|ROWNUM <=|FETCH FIRST/ not found.
Queries:
EXEC sp_executesql N'SELECT [posts].* FROM [posts] /* loading for pp */ ORDER BY [posts].[id] ASC OFFSET 0 ROWS FETCH NEXT @0 ROWS ONLY', N'@0 int', @0 = 11

bin/rails test /usr/local/bundle/bundler/gems/rails-bd4996bdfddb/activerecord/test/cases/relations_test.rb:2147

@aidanharan aidanharan marked this pull request as ready for review September 14, 2023 09:09
@aidanharan aidanharan merged commit 65149cd into main Sep 14, 2023
@aidanharan aidanharan deleted the pretty_print_coerced_test branch September 14, 2023 09:09
lavika pushed a commit to lavika/activerecord-sqlserver-adapter that referenced this pull request Sep 26, 2023
@aidanharan
Coerced pretty print test (rails-sqlserver#1084)
7e9c891
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rails-7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aidanharan