Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding compatibility_level setting #1254

Open
wants to merge 3 commits into
base: 7-2-stable
Choose a base branch
from
Open

adding compatibility_level setting #1254

wants to merge 3 commits into from

Conversation

slavad
Copy link

@slavad slavad commented Oct 25, 2024

@aidanharan do we have tests for the functionality in lib/active_record/connection_adapters/sqlserver/database_tasks.rb ?

I'd like to write tests for my change.

@slavad slavad mentioned this pull request Oct 25, 2024
Open
@slavad
Copy link
Author

slavad commented Nov 7, 2024

Can we merge this?

@aidanharan
Copy link
Contributor

Would need to add some tests before merging. Looks like test/cases/rake_test_sqlserver.rb would be the place to add them.

@slavad
Copy link
Author

slavad commented Nov 11, 2024

sure, will do on the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature need-info rails-7.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavad @aidanharan