finished_at_start/end job filters #111
Conversation
|
Hi @rosa! Don't mean to bother you but in case you missed this this PR is ready for review :) |
|
@Xeitor thanks for letting me know, I'll try to review soon! |
| @@ -23,9 +23,9 @@ class ActiveJob::JobsRelation | |||
| include Enumerable | |||
|
|
|||
| STATUSES = %i[ pending failed in_progress blocked scheduled finished ] | |||
| FILTERS = %i[ queue_name job_class_name ] | |||
| FILTERS = %i[ queue_name job_class_name finished_at_start finished_at_end ] | |||
There was a problem hiding this comment.
I am not sure if we should add this to filters given that the filtering is done natively for solid_queue and i'ts not supported for resque (there isn't a finished status)
| FILTERS = %i[ queue_name job_class_name finished_at_start finished_at_end ] | |
| FILTERS = %i[ queue_name job_class_name ] |
There was a problem hiding this comment.
@rosa what are your thoughts on this?
|
Hi @rosa, hope you are doing great Sorry to bother you, wanted to know if you were able to take a look at the PR :) |
| @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence }.compact | ||
| @job_filters = { job_class_name: params.dig(:filter, :job_class_name).presence, queue_name: params.dig(:filter, :queue_name).presence, | ||
| finished_at_start: params.dig(:filter, :finished_at_start).presence, finished_at_end: params.dig(:filter, :finished_at_end) }.compact | ||
| finished_at_timezoned_filters |
There was a problem hiding this comment.
I think this should be in this method, inlined, and have another helper method to do the parsing.
There was a problem hiding this comment.
i pushed some changes about this, I could move date_with_time_zone method to the helpers and include here
There was a problem hiding this comment.
hi @rosa
just wanted to ping you on this one, no worries however, I know you are probably super bussy with other stuff
|
Hey @Xeitor, so sorry about this huge delay! I haven't had time to focus on Mission Control lately, but it's definitely in the plans for October, I need to spend a week or so just working on all pending PRs and missing features 😳 |
for sure no problem |
Changelog
Issue: #30
PD: I'll split the different filters in different PRs for easier review