Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated page_update javascript is incorrectly escaped. #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Generated page_update javascript is incorrectly escaped. #18

wants to merge 5 commits into from

Commits on Jan 11, 2013

  1. update_page fragments are marked as html_safe even though they have n… 

    …ot been html_escaped. When a fragment is passed as an html tag option, the standard html_escape is bypassed because of the html_safe flag. This leaves quotes (") unescaped, causing HTML errors.
    @esb
    esb committed Jan 11, 2013
    Configuration menu
    Copy the full SHA
    6f9ba8c View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2013

  1. include the X-CSRF-Token header with every Ajax request

    @esb
    esb committed Jan 12, 2013
    Configuration menu
    Copy the full SHA
    2d5fbc1 View commit details
    Browse the repository at this point in the history

  2. Reapply the actionpack 2.2 fix for disable-with, the original submit … 

    …button's name and value need to be submitted as a hidden input.
    @esb
    esb committed Jan 12, 2013
    Configuration menu
    Copy the full SHA
    e2097dc View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2013

  1. Make click event handler on a elements only respond to left clicks

    @esb
    esb committed Jan 13, 2013
    Configuration menu
    Copy the full SHA
    b57e9f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2013

  1. Ensure onclick handlers are escaped only once

    @esb
    esb committed Jan 15, 2013
    Configuration menu
    Copy the full SHA
    f20170f View commit details
    Browse the repository at this point in the history