Make Rails arguments optional #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fundamentally it makes <app_name> part of rails commands area. So, Before: > rails-new
error: the following required arguments were not provided:
<ARGS>...
Usage: rails-new <ARGS>...
For more information, try '--help'.After: > rails-new
Usage:
rails new APP_PATH [options]
Options:
[--skip-namespace] # Skip namespace (affects only isolated engines)
[--skip-collision-check] # Skip collision check
... |
|
If this direction is fundamentally correct I will fix the test. |
|
Yeah. Makes sense to me |
Thank you, I will update the PR. |
Rukomoynikov
force-pushed
the
make_rails_args_nonrequired
branch
from
b0bbc32 to
8f9732f
Compare
Calling rails-new without any arguments fails with error: (error: the following required arguments were not provided: <ARGS>..). Making rails arguments optional allows to simply run rails-new and see what params are required for scaffolding new rails application (for example app name).
Rukomoynikov
force-pushed
the
make_rails_args_nonrequired
branch
from
8f9732f to
a1e4607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Calling rails-new without any arguments fails with error: (error: the following required arguments were not provided: ..). Making rails arguments optional allows to simply run
rails-newand see what params are required for scaffolding new rails application (for example app name).Original and updated behaviour
Without any parameters
Original
Updated
rails-new Starts the docker container and shows the normal ruby on rails generator text: Usage: rails new APP_PATH [options] Options: [--skip-namespace]. # Skip namespace (affects only isolated engines) ...