Make bundle exec blade build success with Ruby 3.3.0dev at 7-0-stable
#47789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the CI failure at 7-0-stable branch since ruby/ruby#7039 https://buildkite.com/rails/rails/builds/94361#0186a504-e06f-4f75-bcb6-df93822f78ed/3283-3286 - Without this commit ```ruby $ ruby -v ruby 3.3.0dev (2023-03-28T07:26:46Z master d766d5346b) [x86_64-linux] $ bundle exec blade build bundler: failed to load command: blade (/home/yahonda/.rbenv/versions/3.3.0-dev/bin/blade) /home/yahonda/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:48:in `initialize': wrong number of arguments (given 3, expected 1..2) (ArgumentError) PARAM2 = Regexp.new "(#{PATTERN::TOKEN})(?:=(#{PATTERN::VALUE2}))?(?:\\Z|;)", '', 'n' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ from /home/yahonda/.rbenv/versions/3.3.0-dev/lib/ruby/gems/3.3.0+0/gems/cookiejar-0.3.3/lib/cookiejar/cookie_validation.rb:48:in `new' ``` - With this commit ```ruby $ ruby -v ruby 3.3.0dev (2023-03-28T07:26:46Z master d766d5346b) [x86_64-linux] $ bundle exec blade build Building assets… $ ``` This commit has been made on top of `7-0-stable` not `main` branch because `blade` has been removed from main branch via rails#46206 `blade` gem depends on `cookiejar` indirectly as follows. `blade` depending on `faye` depending on `em-http-request` depending on `cookiejar` To use `cookiejar` with Ruby 3.3 it needs dwaite/cookiejar#52 merged. Instead of using `https://github.com/koic/cookiejar/tree/suppress_deprecation_warning_for_regexp_n_flag` branch cherry-pick the commit a73e526 because the this pull request may be changed like addressing RuboCop offenses. blade is only used for testing this change should be enough. Co-authored-by: Koichi ITO <[email protected]>
|
@koic This pull request is making use of dwaite/cookiejar#52 so I added you as co-author of this commit. |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Jun 23, 2023
Make `bundle exec blade build` success with Ruby 3.3.0dev at 7-0-stable
|
Backported to the 6-1-stable branch via be19736 |
|
@yahonda Did you delete this repo? https://github.com/yahonda/cookiejar |
zzak
added a commit
to zzak/rails
that referenced
this pull request
Jun 21, 2024
This reverts commit be19736.
zzak
added a commit
to zzak/rails
that referenced
this pull request
Jun 21, 2024
This reverts commit be19736.
eileencodes
added a commit
that referenced
this pull request
Jun 21, 2024
[6-1-stable] Revert "Merge pull request #47789 from yahonda/7-0-stable_ruby33"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This commit addresses the CI failure at 7-0-stable branch since ruby/ruby#7039 https://buildkite.com/rails/rails/builds/94361#0186a504-e06f-4f75-bcb6-df93822f78ed/3283-3286
Detail
This pull request addresses the
bundle exec blade builderrorThis Pull Request has been created because [REPLACE ME]
Additional information
This commit has been made on top of
7-0-stablenotmainbranch becausebladehas been removed from main branch via #46206bladegem depends oncookiejarindirectly as follows.bladedepending onfayedepending onem-http-requestdepending oncookiejarTo use
cookiejarwith Ruby 3.3 it needs dwaite/cookiejar#52 merged. Instead of usinghttps://github.com/koic/cookiejar/tree/suppress_deprecation_warning_for_regexp_n_flagbranch cherry-pick the commit a73e526 because the this pull request may be changed like addressing RuboCop offenses.blade is only used for testing this change should be enough.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]