Skip to content

Batch multi queries #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Batch multi queries #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d936b42
Batch multi queries
djmb Nov 6, 2024
eec30e8
Replace with_multi_batch_size with stub_const
djmb Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions app/models/solid_cache/entry.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,20 @@ class Entry < Record

KEY_HASH_ID_RANGE = -(2**63)..(2**63 - 1)

MULTI_BATCH_SIZE = 1000

class << self
def write(key, value)
write_multi([ { key: key, value: value } ])
end

def write_multi(payloads)
without_query_cache do
upsert_all \
add_key_hash_and_byte_size(payloads),
unique_by: upsert_unique_by, on_duplicate: :update, update_only: [ :key, :value, :byte_size ]
payloads.each_slice(MULTI_BATCH_SIZE).each do |payload_batch|
upsert_all \
add_key_hash_and_byte_size(payload_batch),
unique_by: upsert_unique_by, on_duplicate: :update, update_only: [ :key, :value, :byte_size ]
end
end
end

Expand All @@ -33,9 +37,13 @@ def read(key)

def read_multi(keys)
without_query_cache do
query = Arel.sql(select_sql(keys), *key_hashes_for(keys))
{}.tap do |results|
keys.each_slice(MULTI_BATCH_SIZE).each do |keys_batch|
query = Arel.sql(select_sql(keys_batch), *key_hashes_for(keys_batch))

connection.select_all(query, "SolidCache::Entry Load").cast_values(attribute_types).to_h
results.merge!(connection.select_all(query, "SolidCache::Entry Load").cast_values(attribute_types).to_h)
end
end
end
end

Expand Down
12 changes: 12 additions & 0 deletions test/models/solid_cache/entry_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,18 @@ class EntryTest < ActiveSupport::TestCase
end
end

test "batching multi queries" do
stub_const(Entry, :MULTI_BATCH_SIZE, 2) do
assert_queries_count(2) do
Entry.write_multi([ { key: "hello".b, value: "there" }, { key: "foo".b, value: "bar" }, { key: "baz".b, value: "zab" } ])
end

assert_queries_count(2) do
assert_equal({ "foo" => "bar", "hello" => "there", "baz" => "zab" }, Entry.read_multi([ "hello".b, "foo".b, "baz".b, "bar".b ]))
end
end
end

private
def write_entries(count = 20)
Entry.write_multi(count.times.map { |i| { key: "key#{i}", value: "value#{i}" } })
Expand Down