Setup "pgid" for server running in foreground mode #575
Conversation
… rather than for "background". So it should be changed to `set_pgid if foreground?` See discussion [here](rails@e16e085#r18804964)
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @grosser (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@jonleighton @develop7 @hjwylde plz review |
This command to start a Spring server explicitly in the foreground, which logging to stdout. This will be useful to those who want to run spring more explicitly, but the real impetus was to enable running a spring server inside a Docker container.
|
LGTM |
|
|
|
My memory of the spring code is not super fresh, but I think the code is correct as-is and this should not be merged. The idea of the So I think merging this will result in orphaned spring processes accumulating on users' machines. When running in 'foreground mode', the spring process is never detached. Therefore it will just be up to the parent process to kill it when necessary. If people want to run spring outside of a terminal session, they should do so using |
It's expected that
pgidto be setup for "foreground" running server rather than for "background".So it should be changed to
set_pgid if foreground?See discussion e16e085#r18804964