Repeatable hash type flags bugfix. #769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They treated like every other type now. Instead of merging each key/val into a hash, each flag is treated like it's own hash that should be put into an array. fixes rails#768
|
Nice! Looks good to me - @rafaelfranca ? |
|
bump |
|
Any updates on this fix? I faced this issue and this solves my problem. |
|
This is a change in the behavior and people might be expecting the option to merge instead of having two hashes. I don't think I can accept this change as is. I totally get the current behavior isn't what you want, but we can't assume it is broken and don't have a way to have it. I'd accept an option that would allow the behavior you want though. |
rafaelfranca
added
needs-info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They treated like every other type now. Instead of merging each key/val
into a hash, each flag is treated like it's own hash that should be put
into an array.
fixes #768
🌈