Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export csv with column order expected for decryption #16

Merged
merged 1 commit into from
May 14, 2020
Merged

export csv with column order expected for decryption #16

merged 1 commit into from
May 14, 2020

Conversation

salimhb
Copy link
Member

@salimhb salimhb commented May 14, 2020 •
edited
Loading

lots of magic to workaroud the broken column order railsadminteam/rails_admin#2580

@salimhb salimhb requested review from timomeh and bonflintstone May 14, 2020 16:03
timomeh
timomeh approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@timomeh timomeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (It really seems like it's a bit magic/silent convention involved)

@salimhb salimhb merged commit 3d5f0f5 into master May 14, 2020
@salimhb salimhb deleted the ticket-export-csv branch May 14, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timomeh timomeh timomeh approved these changes

@bonflintstone bonflintstone Awaiting requested review from bonflintstone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salimhb @timomeh