Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nixpacks Bug Report: jsonc is parsed as json #1189

Open
1 task done
mpcref opened this issue Sep 12, 2024 · 0 comments · May be fixed by #1234
Open
1 task done

Nixpacks Bug Report: jsonc is parsed as json #1189

mpcref opened this issue Sep 12, 2024 · 0 comments · May be fixed by #1234
Labels
bug Something isn't working

Comments

@mpcref
Copy link

mpcref commented Sep 12, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Nixpacks parses deno.jsonc as json instead of jsonc.

To reproduce

deno.jsonc:

{
	"tasks": {
		// This comment is valid in jsonc.
		"start": "dist/start"
	}
}
% nixpacks build .
Error: Error reading deno.jsonc as JSON

Caused by:
    key must be a string at line 3 column 3

Expected behavior

deno.jsonc should be parsed as jsonc.

Environment

nixpacks 1.28.1 on macOS 14.6.1 (23G93).
@mpcref mpcref added the bug Something isn't working label Sep 12, 2024
@mpcref mpcref changed the title Nixpacks Bug Report Nixpacks Bug Report: jsonc is parsed as json Sep 12, 2024
@shubhexists shubhexists linked a pull request Dec 3, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(jsonc): added jsonc support shubhexists/nixpacks
1 participant
@mpcref