Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsonc): added jsonc support #1234

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

shubhexists
Copy link
Contributor

@shubhexists shubhexists commented Dec 3, 2024

Fixes #1189

Added jsonc support for deno.jsonc

PR Checklist

  • Docs are updated if needed
  • Tests are added/updated if needed

@coffee-cup coffee-cup added the release/minor Author minor release label Dec 9, 2024
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the one printlnt that should be removed

src/nixpacks/app.rs Outdated Show resolved Hide resolved
@shubhexists
Copy link
Contributor Author

Oops missed it ! Removed the println
Thanks

Copy link
Contributor

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/minor Author minor release stale The pull request is stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nixpacks Bug Report: jsonc is parsed as json
2 participants