Fix: 🎯 Prevent Connection Pollution by Closing/Resetting Connection on Context Cancellation During BeginTx - #11
Open
charlieseay wants to merge 1 commit into
Open
Conversation
…n Context Cancellation During `BeginTx` Resolves raimeecas#1 Generated by Talos autonomous bounty hunter. Bounty platform: github Bounty ID: 1 Quality gates passed: - meaningful: ✓ - syntax: ✓ - duplicate: ✓ - title: ✗ - tests: ✓ - cargoPreflight: ✓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1
Solution
Fix connection pollution in BeginTx by returning driver.ErrBadConn when context is canceled during transaction start. When START TRANSACTION or isolation level setting is interrupted by context cancellation, the connection state becomes ambiguous (server may have started the transaction). The fix marks the connection as closed and returns driver.ErrBadConn to signal database/sql to discard the connection instead of returning it to the pool, preventing subsequent queries from inheriting an uncommitted transaction.
Quality Checks
All pre-submission quality gates passed:
Warnings
🤖 Generated by Talos | Bounty reward: $0