fix: prevent connection pollution on context cancel in BeginTx - #3
Open
jearthliu wants to merge 2 commits into
Open
fix: prevent connection pollution on context cancel in BeginTx#3jearthliu wants to merge 2 commits into
jearthliu wants to merge 2 commits into
Conversation
Return driver.ErrBadConn when context is canceled so the connection is discarded rather than returned to the pool. Closes raimeecas#1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When context is canceled during BeginTx, the connection may already have an active transaction on the server. Returning only the context error lets database/sql reuse the dirty connection. This fix returns driver.ErrBadConn to signal the connection should be discarded. Closes #1.