Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics] token favorites / hiding analytics events #1845

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Feb 19, 2025

What changed (plus any additional context for devs)

  • adds analytics tracking for favorite / unfavorite & hide / unhide

Screen recordings / screenshots

Favorite / unfavorite POW:

Screen.Recording.2025-03-05.at.3.16.24.PM.mov

Hide / unhide POW:

Screen.Recording.2025-03-05.at.3.10.12.PM.mov

What to test

  • do analytics work?
  • are we reporting what we want?

Copy link

linear bot commented Feb 19, 2025

@BrodyHughes BrodyHughes changed the title [WIP] token favorites / hiding analytics events [WIP] [Analytics] token favorites / hiding analytics events Feb 27, 2025
@BrodyHughes BrodyHughes changed the title [WIP] [Analytics] token favorites / hiding analytics events [Analytics] token favorites / hiding analytics events Mar 5, 2025
@BrodyHughes BrodyHughes marked this pull request as ready for review March 5, 2025 21:27
@walmat
Copy link
Contributor

walmat commented Mar 27, 2025

@BrodyHughes can we wait on this one until my networks stuff goes in? They both touch this file and will need a rebase.

@brunobar79
Copy link
Member

@BrodyHughes needs to rebase after #1847

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some small nits.

@BrodyHughes BrodyHughes requested a review from derHowie March 28, 2025 20:48
@BrodyHughes BrodyHughes requested a review from walmat March 31, 2025 18:56
@BrodyHughes BrodyHughes closed this Apr 1, 2025
@BrodyHughes BrodyHughes reopened this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants