fix swap test #6060
Merged
fix swap test #6060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
Aug 29, 2024
Comment on lines
112
to
113
| console.log('testID', testID, 'aa'); | ||
|
|
There was a problem hiding this comment.
Suggested change
| console.log('testID', testID, 'aa'); |
walmat
reviewed
Aug 29, 2024
| @@ -79,10 +79,11 @@ export function valueBasedDecimalFormatter({ | |||
| // Default to normal rounding if no rounding mode is specified | |||
| roundedAmount = divWorklet(roundWorklet(mulWorklet(amount, factor)), factor); | |||
| } | |||
| console.log('maximumDecimalPlaces', maximumDecimalPlaces); | |||
There was a problem hiding this comment.
Suggested change
| console.log('maximumDecimalPlaces', maximumDecimalPlaces); |
estebanmino
force-pushed
the
@esteban/fix-swap-test
branch
2 times, most recently
from
07fd741 to
580f8be
Compare
This reverts commit 9e591cc.
estebanmino
force-pushed
the
@esteban/fix-swap-test
branch
from
580f8be to
f6c4d96
Compare
walmat
approved these changes
Aug 29, 2024
jinchung
reviewed
Aug 29, 2024
src/redux/gas.ts
Outdated
| }) | ||
| )?.connection?.url; | ||
| const provider = getProvider({ chainId: ChainId.mainnet }); | ||
| const providerUrl = provider?.connection?.url; | ||
| if (isHardHat(providerUrl)) { |
There was a problem hiding this comment.
we could replace this with the connectedToHardhat directly instead of dealing with providerUrl and the isHardHat check?
There was a problem hiding this comment.
i went ahead and also removed all instances of isHardhat
jinchung
reviewed
Aug 29, 2024
| @@ -1,6 +1,6 @@ | |||
| import { Contract } from '@ethersproject/contracts'; | |||
| import { keyBy, mapValues } from 'lodash'; | |||
| import { web3Provider } from '@/handlers/web3'; // TODO JIN | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
using
useConnectedToHardhatStorehook to fetch balances, so when you switch to hardhat all assets balances will update correctlyWhat changed (plus any additional context for devs)
Screen recordings / screenshots
What to test