Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e flakiness / errors #6084

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Fix e2e flakiness / errors #6084

merged 9 commits into from
Sep 6, 2024

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Sep 5, 2024

CI IS BORKED

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert the changes to the project.pbxproj file

@BrodyHughes BrodyHughes changed the title fix Fix e2e flakiness / errors Sep 6, 2024
@BrodyHughes BrodyHughes removed the request for review from brunobar79 September 6, 2024 17:00
@brunobar79
Copy link
Member

Launch in simulator or device for 1c410e9

@BrodyHughes BrodyHughes requested review from benisgold and removed request for jinchung September 6, 2024 18:54
@brunobar79
Copy link
Member

Launch in simulator or device for 4570081

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@BrodyHughes BrodyHughes merged commit 182ba51 into develop Sep 6, 2024
8 checks passed
@BrodyHughes BrodyHughes deleted the brody/fix-ci-e2e branch September 6, 2024 21:54
greg-schrammel pushed a commit that referenced this pull request Sep 11, 2024
* fix

* test

* revert

* @walmat related fixes

* @walmat related fixes

* okay disabling the test again, the experimental flag didnt fix it

* okay disabling the test again, the experimental flag didnt fix it

* fix disabled NFTs in testing and rely on remote config for prod

* .
walmat added a commit that referenced this pull request Sep 13, 2024
* add degen native asset

* remove NATIVE_ASSETS_MAP_PER_CHAIN

* remove Address castings

* bump iOS and Android version to v1.9.38 (#6081)

* Fix e2e flakiness / errors (#6084)

* fix

* test

* revert

* @walmat related fixes

* @walmat related fixes

* okay disabling the test again, the experimental flag didnt fix it

* okay disabling the test again, the experimental flag didnt fix it

* fix disabled NFTs in testing and rely on remote config for prod

* .

* add 60 min timeout (#6090)

* fix tophat triggers (#6089)

* Fix url creation for stale balance param (#6091)

* fix wrong id (#6078)

* change to id

* also fix clicks

* Add rc-push script (#6088)

* add rc-push script

* source .env

* Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows (#6072)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fixes opacity on mwp sign txn sheet (#6083)

* change opacity on mwp route source too

* switch to includes

* update env (#6077)

* fix missing dapp metadata for eth actions (#6086)

* fix missing dapp metadata for eth actions

* use isHandshakeAction helper function

* Update src/components/MobileWalletProtocolListener.tsx

Co-authored-by: Bruno Barbieri <[email protected]>

---------

Co-authored-by: Bruno Barbieri <[email protected]>

* Revert "Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows …" (#6095)

This reverts commit 431459a.

* Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows (#6072)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows …" (#6095)

This reverts commit 431459a.

* Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows (#6072)

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.1.7.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4.1.7)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows …" (#6095)

This reverts commit 431459a.

* fix: send (#6093)

* fix

* lint

* userAssetsStore refactor (#6015)

* done

* change userAssetsStoreCache type

* mid refactor

* refactor

* dont cast to Address

* more

* more

* rm address param

* fix caching

* select address

* comments

* hardhat

* lint

* Fix wrong messages during MWP Flow (#6094)

* add logging for pkey errors

* fix keychain error handling

* checksum address before keychain lookup

* remove invalid chainId param from tx

* Update src/keychain/index.ts

* Update src/keychain/index.ts

Co-authored-by: Jin <[email protected]>

* Explicitly return UserCanceled error for code strings 10 and 13

* Remove returning -3 explicit error code

* Use enum values instead of primitives for error codes for readability

---------

Co-authored-by: Jin <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Ibrahim Taveras <[email protected]>
Co-authored-by: brdy <[email protected]>
Co-authored-by: Bruno Barbieri <[email protected]>
Co-authored-by: Jin <[email protected]>
Co-authored-by: Matthew Wall <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Esteban Miño <[email protected]>
Co-authored-by: Ben Goldberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants