Rework remote promo sheet logic / designs#6085
Merged
Conversation
Contributor
Contributor
brunobar79
requested review from
derHowie
and removed request for
estebanmino
benisgold
approved these changes
Sep 13, 2024
Contributor
benisgold
left a comment
benisgold
left a comment
There was a problem hiding this comment.
looks good! left 1 comment
also, not sure if related to your pr, but i believe the swaps promo sheet was intended to always show as "dark mode" themed. kinda irrelevant now
Contributor
|
@walmat approved, but https://github.com/rainbow-me/rainbow/blob/%40matthew/improve-remote-promo-sheets/src/navigation/types.ts#L70 this line might need a types cleanup |
Contributor
Contributor
Contributor
walmat
commented
Sep 16, 2024
| }, [goBack, navigate, data?.promoSheet]); | ||
|
|
||
| if (!data?.promoSheet || error) { | ||
| if (!data?.promoSheet) { |
Contributor
Author
There was a problem hiding this comment.
we only shouldn't show if we don't have the data, regardless of error
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-1836
What changed (plus any additional context for devs)
Addresses some oddities happening around remote promo sheets.
Screen recordings / screenshots
What to test