Claim as X #6193
Claim as X #6193
Conversation
…@benisgold/crosschain-swaps-rap
…@benisgold/crosschain-swaps-rap
…@benisgold/crosschain-swaps-rap
There was a problem hiding this comment.
tried out both claim types, swap, xchain swap. No issues on those txs. Good stuff!
proof of work: https://www.loom.com/share/e1ef4389ecb446e2803e0fa495c1876d
| @@ -735,7 +735,7 @@ export function PointsContent() { | |||
| <Box gap={24}> | |||
| {rewardsEnabled && (showClaimYourPoints || showMyEarnings) && ( | |||
| <Box gap={20}> | |||
| {showClaimYourPoints && !isReadOnlyWallet && <ClaimCard claim={claimableBalance.display} value={claimablePrice} />} | |||
There was a problem hiding this comment.
Was this related or something we were hardcoding during dev?
There was a problem hiding this comment.
i decided to enable the ClaimCard (eth rewards) for read only wallets so i can also display eth rewards in the claimables section of the wallet screen for read only wallets. since that is the default behavior for claimables in general
| throw error; | ||
| } | ||
|
|
||
| const receipt = await tx?.wait(); |
There was a problem hiding this comment.
| const receipt = await tx?.wait(); | |
| const receipt = await tx.wait(); |
already checking above
| transaction, | ||
| }); | ||
|
|
||
| const tx = await wallet?.provider?.getTransaction(result.result.hash); |
There was a problem hiding this comment.
| const tx = await wallet?.provider?.getTransaction(result.result.hash); | |
| const tx = await wallet.provider?.getTransaction(result.result.hash); |
should be defined based on args types
There was a problem hiding this comment.
Looks good aside from the throw that I mentioned earlier @benisgold
…@benisgold/crosschain-swaps-rap
|
a couple small q's to ben via DM about expected behavior, but QA looks mostly good. Will approve once we talk it out. |
…@benisgold/crosschain-swaps-rap
benisgold
force-pushed
the
@benisgold/crosschain-swaps-rap
branch
from
48354e8 to
9afef38
Compare
src/raps/claimClaimable.ts
Outdated
| const unlock = createNewAction('unlock', { | ||
| fromAddress: accountAddress, | ||
| assetToUnlock: assetToSell, | ||
| chainId, | ||
| contractAddress: quote.to as Address, |
…@benisgold/crosschain-swaps-rap
Fixes APP-1787
I'm sorry about the commits
Context
Two types of claimables:
Transaction: Are claimed on-chain
Sponsored: Claims still occur on-chain, but can only be initiated via an off-chain request. Rainbow doesn't always receive a tx confirmation from these claims.
This feature lets users swap/bridge their claimable to other tokens/networks. We sandwich (rap) together the claim + approval/swap/bridge transactions by using our internal
rapsmodule, which manages the nonce of each tx to ensure that the user does not execute any other txs while still executing the claim rap. For this reason, the feature is only compatible with transaction-type claimables, since we require the nonce from the claim tx to confidently execute the following transactions. If you see dropdown menus to select tokens/networks to swap to on the claim panel, you are looking at a transaction-type claimable.High Level Claim Flow
claimStatus = "notReady"claimStatus = "ready". Now the claim button is enabled.Details on Token/Network Selection
The claimable asset and network should be selected by default. The tokens that appear in the dropdown menu are the claimable asset, ETH, USDC, and the native asset of the currently selected network. All networks are available on the dropdown menu. However, not all tokens/networks are compatible. For example, if the selected token is Degen and the user tries to also select ApeChain as the network that wouldn't be possible. To mitigate this, once an item from the first dropdown is selected (whether it is token/network), the options of the 2nd, unused dropdown are automatically constrained by the 1st selection. Each dropdown has a "reset" option that will reset both dropdowns back to the default so they can see all the options again.
Screen recordings / screenshots
https://www.loom.com/share/7e4aafd11dbc47c6b20bde43ba2d412b
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-12-04.at.16.08.21.mp4
What to test
Download the TF 1.9.47 (39) and claim your claimables if you have any. Before claiming try a bunch of different swap combos and see if gas estimation works properly / makes sense.