Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE]: Convert Discover to Typescript + cleanup discover context #6226

Merged
merged 10 commits into from
Nov 2, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Oct 22, 2024

What changed (plus any additional context for devs)

Converts discover screen content to use typescript. Fixes up a lot of the redundancy with discover screen context too

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-22.at.15.26.43.mp4

What to test

Discover screen functionality

  • searching
  • clearing
  • scroll to top
  • etc etc

@walmat walmat marked this pull request as ready for review October 22, 2024 19:58
@brunobar79
Copy link
Member

Launch in simulator or device for 805ede8

@brunobar79
Copy link
Member

Launch in simulator or device for b5efb76

@brunobar79
Copy link
Member

Launch in simulator or device for 4131408

@brunobar79
Copy link
Member

Launch in simulator or device for 810d67e

@walmat walmat merged commit 22b9954 into develop Nov 2, 2024
8 checks passed
@walmat walmat deleted the @matthew/discover-typescript branch November 2, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants