fix gas button stuck on loading#6241
Merged
walmat merged 6 commits intofeat/remove-swaps-v1from Oct 30, 2024
Merged
Conversation
ibrahimtaveras00
approved these changes
Oct 30, 2024
Contributor
ibrahimtaveras00
left a comment
ibrahimtaveras00
left a comment
There was a problem hiding this comment.
fix looks good on both OS's 👍🏽
jinchung
pushed a commit
that referenced
this pull request
Oct 31, 2024
* start on ripping out old swaps * Update package.json * clean up lint * add pbx? * tslint is a liar * fixed it * rm graph * revert changes to pbx * Swaps v2 cleanup duplicates / unused utils (#6202) * remove bunch of duplicate utils * remove unused hooks and remove duplicate AnimatedBlurView * remove multiple getUniqueIds and only keep worklet version * reorder worklets * remove getCrosschainSwapServiceTime from handlers/swap * remove ExchangeSearch * remove unused NetworkSwitcher components * rename useFeePanelInputRefs to useFeesPanelInputRefs * remove swapSearch and walletFilter * delete unused useMinRefuelAmount hook * delete unused exchangeModalTypes file * remove unused selectUserAssetsListByChainId selector * change getAddressAndChainIdFromUniqueId to work for both networks and chains * remove duplicate buildLocalizedTimeUnitString util * remove duplicate buildLocalizedTimeUnitString util * remove TokenSelectionButton * remove SendFab * replace a couple accessors to native assets that could be sync * remove unused fromChainId from useSearchCurrencyList * remove unused isCrosschainSearch from useSearchCurrencyList * bring back navigation hook that prevents readOnly wallets from navigating to buy, send, and swaps * clean up crossChainServiceTime and remove traces * add swaps v2 comment * fix initial asset missing on expanded state navigation (#6240) * fix gas button stuck on loading (#6241) * fix gas button issues? * rm poll causing infinite loop * remove some weird checks * maybe? * move unused vars to swaps util
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes APP-1975
What changed (plus any additional context for devs)
For some reason even after gas prices resolve on the send sheet the animated number was stuck on 0, this should fix it.
Screen recordings / screenshots
What to test