Fix SignTransactionSheet not disabling button on authorization #6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
commented
Nov 4, 2024
| @@ -2908,6 +2908,7 @@ | |||
| "buttons": { | |||
| "cancel": "Cancel", | |||
| "confirm": " Confirm", | |||
| "confirming": "Confirming", | |||
There was a problem hiding this comment.
Do we want a different copy here?
walmat
commented
Nov 4, 2024
| @@ -20,11 +20,10 @@ type BalanceCheckParams = { | |||
| }; | |||
|
|
|||
| export const useHasEnoughBalance = ({ isMessageRequest, walletBalance, chainId, selectedGasFee, req }: BalanceCheckParams) => { | |||
| const [isBalanceEnough, setIsBalanceEnough] = useState<boolean>(); | |||
| const [isBalanceEnough, setIsBalanceEnough] = useState<boolean>(isMessageRequest); | |||
There was a problem hiding this comment.
immediately set to true if we're signing a message.
walmat
changed the title
walmat
commented
Nov 26, 2024
derHowie
approved these changes
Dec 3, 2024
benisgold
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1969
What changed (plus any additional context for devs)
Disables sign transaction button once the user prompts for authentication and enables again afterward
Screen recordings / screenshots
n/a
What to test
happy paths for message signing, txn signing, etc.