Improve nonce management logic for private mempool handling by jinchung · Pull Request #6277 · rainbow-me/rainbow

jinchung · 2024-11-21T22:43:12Z

Fixes APP-2048
Fixes APP-2040

What changed (plus any additional context for devs)

Add a placeholder in networks config for per-network configuration for private mempool timeout (default is 2 mins)
Populate timestamp param on new txns to keep it up to date when a txn is submitted or re-submitted (speed up/ cancel)
Update the nonce management logic as per specification (link in Linear ticket)
Add support for a batchedProvider from ethers v5 to submit the pending and latest txCount requests together
Removes flashbots logic and UI

Screen recordings / screenshots

ScreenRecording_12-06-2024.22-53-04_1.MP4

What to test

Mix of private mempool and public mempool transactions

linear · 2024-11-21T22:43:15Z

APP-2048 Implement nonce management logic

jinchung · 2024-11-21T22:44:06Z

    hash: tx.hash,
    nonce: tx.nonce,
    protocol: tx.protocol,
+    timestamp: Date.now(),


this function is used from both the "add new txn" flow and the "udpate txn" flow (for speed up / cancel)

jinchung · 2024-11-21T22:44:42Z

+
+  const pendingTxCountRequest = provider.getTransactionCount(address, 'pending');
+  const latestTxCountRequest = provider.getTransactionCount(address, 'latest');
+  const [pendingTxCountFromPublicRpc, latestTxCountFromPublicRpc] = await Promise.all([pendingTxCountRequest, latestTxCountRequest]);


batched provider will batch requests sent on the provider in the same event loop in ethers v5

ibrahimtaveras00

all fixes look good, QA Passed 👍🏽

jinchung · 2024-12-02T18:40:56Z

-        setNonce({
-          address,
-          chainId,
-          currentNonce: currentProviderNonce > currentNonceForChainId ? currentProviderNonce : currentNonceForChainId,


this processNonces function is no longer needed - we don't use latestConfirmedNonce and the currentNonce will have been made up to date already when adding / updating the pending txn

jinchung · 2024-12-02T18:43:45Z

-  });
+  const localNonceData = getNonce({ address, chainId });
+  const localNonce = localNonceData?.currentNonce || 0;
+  if (transaction.nonce > localNonce) {


now that we can pick up "gapped" nonces, we should check that the txn we are adding / updating has a larger nonce than what already exists before updating via setNonce

linear · 2024-12-02T19:26:49Z

APP-2040 Remove flashbots from swap settings

derHowie

code looks great, one v small suggestion 🥳

brunobar79 · 2024-12-03T22:22:18Z

Launch in simulator or device for 6661342

brunobar79 · 2024-12-04T21:58:53Z

Launch in simulator or device for 6d41812

… updating pending txns

…new txns that are using a gapped nonce

…st order

…ddNewtx and updateTxn have been consolidated and a gapped nonce can be picked up

… clobbers over data during for loop

brunobar79 · 2024-12-08T21:42:50Z

Launch in simulator or device for 04969b2

jinchung commented Nov 21, 2024

View reviewed changes

jinchung requested a review from brunobar79 November 21, 2024 22:45

jinchung commented Nov 21, 2024

View reviewed changes

Comment thread src/chains/index.ts

brunobar79 reviewed Nov 22, 2024

View reviewed changes

Comment thread src/handlers/web3.ts Outdated

Comment thread src/chains/index.ts

jinchung force-pushed the @jin/nonce-mgmt branch from ba7b920 to d1da797 Compare November 27, 2024 18:32

ibrahimtaveras00 approved these changes Nov 27, 2024

View reviewed changes

jinchung requested a review from derHowie December 2, 2024 17:49

jinchung commented Dec 2, 2024

View reviewed changes

jinchung force-pushed the @jin/nonce-mgmt branch from 7064bfe to c53d8a5 Compare December 2, 2024 19:04

brunobar79 added the release for release blockers and release candidate branches label Dec 2, 2024

jinchung marked this pull request as ready for review December 2, 2024 19:20

jinchung force-pushed the @jin/nonce-mgmt branch from c53d8a5 to 8954bc7 Compare December 3, 2024 04:23

derHowie approved these changes Dec 3, 2024

View reviewed changes

Comment thread src/state/nonces/index.ts

jinchung force-pushed the @jin/nonce-mgmt branch from 8954bc7 to 92ce733 Compare December 3, 2024 21:27

jinchung force-pushed the @jin/nonce-mgmt branch from 92ce733 to e24d8c8 Compare December 4, 2024 18:42

brunobar79 removed the release for release blockers and release candidate branches label Dec 5, 2024

jinchung marked this pull request as draft December 6, 2024 19:57

jinchung added 7 commits December 6, 2024 22:01

Add support for default private mempool timeout of 2 minutes

23584c2

fix: rename chainsPrivateMempoolTimout

973cf95

Use existing timestamp to update tx timestamp for new pending txns or…

6ab1587

… updating pending txns

Update nonce management logic

e1c0d81

Wrap latest and pending tx count calls in Promise.all

ead6df0

Add support for batched provider

4749e5e

Use batched provider in nonce manager logic

34dbe95

jinchung added 20 commits December 6, 2024 22:05

Remove flashbots from explain sheet

9f5892e

Remove flashbots from raps

7bc6f76

Remove getFlashbotsProvider

9fcac1c

Remove flashbots from remote config defaults

eb496c2

Remove flashbots from txns parser

8bf5efa

Remove flashbots row from swap settings panel

6db8c8d

Remove flashbots from animated swap styles

107a8a2

Remove supported flashbots chain ids list

1fa4586

Remove flashbots in analytics and experimental config

b3bd6e8

Remove flashbots from GasSpeedButton and FeesPanel

9717659

Remove flashbots min tip constant

94d37a6

Remove en_US flashbots copy

1b17bdb

Adding new txn to behave similar to updating txns in order to handle …

6e07aa1

…new txns that are using a gapped nonce

Fix addPendingTxn to ensure pending txns are ordered by nonce

ccfcc9d

Simplify updateTransaction which matches addNewTransaction

c7e5529

Support pendingTransactions function for returning txns in recent fir…

a3dd185

…st order

Cleanup sort function

16b94f1

Fix: setNonce only when nonce is greater than currentNonce now that a…

a0e49ed

…ddNewtx and updateTxn have been consolidated and a gapped nonce can be picked up

Set up HARDHAT_RPC_URL constant

f4bc627

Fix: array sort sorts in place

a0d45f8

jinchung force-pushed the @jin/nonce-mgmt branch from e24d8c8 to a0d45f8 Compare December 7, 2024 03:05

jinchung marked this pull request as ready for review December 7, 2024 03:56

jinchung added 5 commits December 6, 2024 22:59

Remove flashbots from latest changes for navigateToSwaps

218bea6

Add a comment for getNextNonce logic

12a45d2

Remove unnecessary updating of nonces from pending txn watcher as it…

1b82550

… clobbers over data during for loop

Fix: off by one error when comparing local nonce with pending txn count

da2219e

Remove flashbots reference

246d234

jinchung merged commit 044daae into develop Dec 10, 2024

jinchung deleted the @jin/nonce-mgmt branch December 10, 2024 21:58

Conversation

jinchung commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Uh oh!

linear Bot commented Nov 21, 2024

Uh oh!

jinchung Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

Uh oh!

jinchung Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

jinchung Dec 2, 2024

Choose a reason for hiding this comment

Uh oh!

linear Bot commented Dec 2, 2024

Uh oh!

derHowie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brunobar79 commented Dec 3, 2024

Uh oh!

brunobar79 commented Dec 4, 2024

Uh oh!

brunobar79 commented Dec 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jinchung commented Nov 21, 2024 •

edited

Loading

jinchung Nov 21, 2024 •

edited

Loading