Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet Switcher v2 #6318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet Switcher v2 #6318
Changes from 51 commits
778117b
74b4019
71d6b46
e8fc4f8
2fa3f66
089a164
4b8b989
63d9683
54e2911
2339bd0
b85e0c7
5134fcc
a8ede2b
10faef3
f69dcdf
6455f0b
6cb4663
e1bfada
e8d706d
b384ec7
8ed6aec
120483c
ccbf096
8b63d33
45c4b1a
959b774
1ec4446
d137c40
746b79b
b4c1691
41925ed
50b5e04
dd774e2
0b778ef
aa75d33
b116d1a
1ffd763
2d582fa
af1e1b6
ff44d3e
174f57d
dbf1131
f4017fe
76470ff
b713e71
69ca2b4
69bc587
f445acd
3e9572e
b3a9702
a3b285b
c534b4a
90bd1e7
e6a8307
286b901
9f71e17
3fe3ed8
0bbdd5c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually not sure we ever need to use the bare
DropdownMenuItem
. Can't we optimistically assume it's aDropdownMenuCheckboxItem
and just not show the checkmark by settingvalue={undefined}
? Unsure, but worth trying if it simplifies thisThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Android an empty checkbox gets automatically added when using the
DropdownMenuCheckboxItem
. The value prop is required forDropdownMenuCheckboxItem
and can't be set to undefined. I could change it to assume undefined value types should use the other component, but I don't think there is a way tot get around needing to conditionally use theDropdownMenuCheckboxItem
orDropdownMenuItem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great animation! Unrelated to this PR, but just popped into my head. We should come up with a strategy for reducing animations when a user has Accessibility > Reduced Motion toggled to on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe reanimated handles the reduced motion system setting by default: https://docs.swmansion.com/react-native-reanimated/docs/guides/accessibility/