Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken backups e2e #6365

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Fix broken backups e2e #6365

merged 5 commits into from
Dec 23, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Dec 20, 2024

What changed (plus any additional context for devs)

I fixed a testID but actually broke e2e in the process. Also there was another happy path for manual backups that conditionally was failing

Screen recordings / screenshots

n/a

What to test

e2e should be green for 7_manualBackup.spec.ts

@walmat
fix broken testID for backups and condiiton that prevents manually ba…
99578d9 
…cked up wallets from being marked as backed up
@brunobar79
Copy link
Member

Launch in simulator or device for 07e4698

@brunobar79
Copy link
Member

Launch in simulator or device for 061c155

@brunobar79
E2E improvements (#6369)
e45164a 
* goodbye hardhat => hello anvil

* replace usage of IS_TESTING in favor of IS_TEST

* fix detox config

* more refactor

* anvil already installed in CI machines

* fix anvil shutdown

* retry per file so we can handle anvil separately

* fix inverse logic
@socket-security Socket Security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/@fastify/[email protected], npm/@noble/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomiclabs/[email protected], npm/@nomiclabs/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@sentry/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@brunobar79
Copy link
Member

Launch in simulator or device for 18b5a56

@derHowie derHowie merged commit 7a2ade3 into develop Dec 23, 2024
8 checks passed
@derHowie derHowie deleted the @matthew/fix-backups-e2e branch December 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

@BrodyHughes BrodyHughes Awaiting requested review from BrodyHughes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walmat @brunobar79 @derHowie