Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swap submit button getting stuck on 'Fetching' #6382

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

christianbaroni
Copy link
Member

@christianbaroni christianbaroni commented Jan 6, 2025

What changed (plus any additional context for devs)

  • isLoadingUserAssets was being reset to true during app launch, and not set to false until user assets data was next fetched and set via RQ, resulting in the swap submit button often getting stuck in a 'Fetching' state after a fresh app launch (until the next user assets fetch)
  • This is where it's causing the swap submit button issue:
    if (!gasSettings || !estimatedGasLimit || !quote || 'error' in quote || isLoadingNativeNetworkAsset) return;

Screen recordings / screenshots

What to test

@brunobar79
Copy link
Member

Launch in simulator or device for 56fe354

@christianbaroni christianbaroni merged commit c64d355 into develop Jan 6, 2025
8 checks passed
@christianbaroni christianbaroni deleted the @christian/swaps-fetching-fix branch January 6, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants