Skip to content

Conversation

@rakibulhaq
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 29, 2025 09:27
@rakibulhaq rakibulhaq linked an issue Jun 29, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tests for various components of the shondesh project, ensuring that constants, formatters, and notification channels behave as expected.

  • Added tests for Severity constant values and error handling.
  • Introduced new tests for Slack, Telegram, Webhook, and Email channels.
  • Updated webhook API call logic to properly await the response using an async context.

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/shondesh/utils/test_constants.py Tests for Severity constants and their error handling.
tests/shondesh/formatters/test_slack_message_formatter.py Tests for formatting Slack messages with appropriate escaping.
tests/shondesh/formatters/test_dict_table_formatter.py Tests for consistent dict-to-table formatting.
tests/shondesh/channels/test_webhook.py Async tests for webhook channel’s sending logic.
tests/shondesh/channels/test_telegram.py Tests covering Telegram channel initialization and messaging.
tests/shondesh/channels/test_slack.py Async tests for Slack channel message sending.
tests/shondesh/channels/test_email.py Async tests for Email channel behavior and environment-based config handling.
shondesh/formatters/slack_message_formatter.py Minor adjustment in returning formatted Slack message fields.
shondesh/channels/webhook.py Updated async logic for handling webhook responses.
Comments suppressed due to low confidence (1)

tests/shondesh/utils/test_constants.py:5

  • Test functions must start with 'test_' to ensure pytest auto-discovers them. Please rename 'returns_correct_value_for_info' to 'test_returns_correct_value_for_info'.
def returns_correct_value_for_info():

@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rakibulhaq rakibulhaq merged commit d44dab2 into main Jun 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more tests

2 participants