Skip to content

build: Move gloabl.json to the backend_csharp - #298

Merged
ralfbiedert merged 1 commit into
ralfbiedert:masterfrom
OleRoss:build/move-global-json-from-repo-root
Jul 23, 2026
Merged

build: Move gloabl.json to the backend_csharp#298
ralfbiedert merged 1 commit into
ralfbiedert:masterfrom
OleRoss:build/move-global-json-from-repo-root

Conversation

@OleRoss

@OleRoss OleRoss commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

See comment here.

Moved and updated the Justfile

@OleRoss

OleRoss commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

@ralfbiedert I saw the tests failed but I don't know what should have changed the behavior in this PR. Have you seen this before or is this a flakyness that was introduced with xunit.v3 somehow?

I can't reproduce locally

@ralfbiedert
ralfbiedert force-pushed the build/move-global-json-from-repo-root branch from fa289e9 to c327eba Compare July 22, 2026 08:57
@ralfbiedert

ralfbiedert commented Jul 22, 2026

Copy link
Copy Markdown
Owner

There is apparently a codegen bug emitting a bad Arc<Self>-backed *const Self to &mut self cast where it shouldn't, causing UB, which is a bit flaky to trigger. Technically not required, let me land the fix for that first so you can get a green build.

@ralfbiedert
ralfbiedert force-pushed the build/move-global-json-from-repo-root branch from c327eba to d15d286 Compare July 22, 2026 15:51
@ralfbiedert
ralfbiedert merged commit a0d5e92 into ralfbiedert:master Jul 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants